Am 22.04.22 um 17:52 schrieb Frank Lichtenheld:


Arne Schwabe <a...@rfc2549.org> hat am 22.04.2022 15:40 geschrieben:
diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c
index 4fbe3c1a3..910268333 100644
--- a/src/openvpn/mudp.c
+++ b/src/openvpn/mudp.c
@@ -39,6 +39,20 @@
  #include <sys/inotify.h>
  #endif
+static bool
+do_pre_decrypt_check(struct multi_context *m)
+{
+    if (!m->top.c2.tls_auth_standalone)
+    {
+        return false;
+    }
+    if (!tls_pre_decrypt_lite(m->top.c2.tls_auth_standalone, &m->top.c2.from, 
&m->top.c2.buf))
+    {
+        return false;
+    }
+    return true;

Shouldn't this be
if (!m->top.c2.tls_auth_standalone)

Yes. But then again the whole line is dead code anyway because m->top.c2.tls_auth_standalone is always initialised.

Arne


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to