On 06/04/2022 14:44, Timo Rothenpieler wrote:
--- a/configure.ac
+++ b/configure.ac
@@ -794,6 +794,25 @@ dnl
esac
fi
+dnl
+dnl Depend on libcap-ng on Linux
+dnl
+case "$host" in
+ *-*-linux*)
+ PKG_CHECK_MODULES([LIBCAPNG],
+ [libcap-ng],
+ [have_libcapng="yes"],
do we really need have_libcapng? it seems it is not used further in
configure.ac
I have little to no experience with autotools, and I think this is
straight up copied from the openvpn3 setup.
That's probably right.
Can I just leave the line empty? Or put empty [] there?
Yes, [] should suffice. That said, it makes no big difference if it is
there or not. If needed to check ("test") if libcap-ng is available or
not, this checks needs to be added again though.
That said, we do not have a consistent way of using PKG_CHECK_MODULES()
in general. We have at least 4 different ways in use today.
Probably something to clean-up some day later.
--
kind regards,
David Sommerseth
OpenVPN Inc
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
