On 25/03/2022 16:04, Arne Schwabe wrote:
Am 25.03.22 um 08:21 schrieb Michael Baentsch:
Thanks very much for the quick and thorough feedback. Indeed your last
question is pivotal making the patch _much_ simpler (attached): The
problem manifests itself only in the presence of providers introduced
in OpenSSL3.0. At the same time, the curve name causing the "dance
code" is permitted as of OpenSSL3.0...
So all other observations below are moot/should be resolved with the
much simpler new patch attached. Feel free to delete/amend the comment
changes as you see fit.
Thanks v2 looks much better code wise and gets ack from me. To commit
the patch could you either send the patch in git format-message format
or provide a commit subject and text so we can make full commit of your
patch?
We also need the patch to bear the sign-off-by line, so better create an
actual git commit and export it via git-format-patch.
Cheers,
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
