This one does not need much brains to review - "does it apply" and
"does it break 'make distcheck'" (yes, and no).
The reason why this plugin is deleted is because the new multi-auth
plugin does mostly the same thing, "but more" - and it's 90% the same
code, so not much to be learned from the older one anymore.
For 2.5 and 2.4 branches, after some discussion on IRC, it makes sense
to leave defer/simple alone - it still has "PF" support, which
defer/auth-multi does not have (and does not need). So, unlike
master, there is something to be learned from having both plugins,
and someone might even make use of the "simple" feature set...
Your patch has been applied to the master branch.
commit d816207bc2fe1ee5a04c394b215d50123cb25aad (master)
Author: David Sommerseth
Date: Sun Mar 13 20:31:54 2022 +0100
plugins: Remove defer/simple.c sample plugin
Signed-off-by: David Sommerseth <dav...@openvpn.net>
Acked-by: Antonio Quartulli <anto...@openvpn.net>
Message-Id: <20220313193154.9350-4-open...@sf.lists.topphemmelig.net>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23933.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
