Hi, On Thu, Feb 17, 2022 at 03:32:41PM +0100, Antonio Quartulli wrote: > At the moment we have tls_crypt_kt() and auth_token_kt that basically do > the same thing, but with different algorithms used to inizialise the > structure. > > In order to avoid code duplication and copy/paste errors, unify code and > make it parametric, so that it can be re-used in various places. > > Signed-off-by: Antonio Quartulli <a...@unstable.cc>
NAK. Please run "make check" on your patches :-)
../../../../openvpn/tests/unit_tests/openvpn/test_auth_token.c:95:15: warning:
implicit declaration of
function 'auth_token_kt' is invalid in C99
[-Wimplicit-function-declaration]
ctx->kt = auth_token_kt();
^
../../../../openvpn/tests/unit_tests/openvpn/test_auth_token.c:95:13: error:
assigning to 'struct key_type'
from incompatible type 'int'
ctx->kt = auth_token_kt();
^ ~~~~~~~~~~~~~~~
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
