Hi,

Thanks for testing.

> original patch does not apply

Indeed it doesn't apply anymore since recent changes to vcxproj files.
I have rebased it.

> minor build issues still there: test · chipitsine/openvpn@eeff765 (github.com)

Those are likely because this was not applied
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21774.html
to your 2.5 branch.
I have mentioned it in the patch email, but not in a commit message.

> also, I have a question on <SDLCheck>true</SDLCheck>, in your patch it is not 
> applied to all configurations, but to few of them. is it on purpose ?

For some reasons I missed debug configurations in some projects, I'll add those.

Here are my GHa builds:

master: https://github.com/lstipakov/openvpn/actions/runs/1857589993
release/2.5: https://github.com/lstipakov/openvpn/actions/runs/1857547158

-- 
-Lev


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to