Combining Arne's ACK for 16+17 into this one.  As far as I can see
(not checked line-by-line) this is indeed the same code, just squashed
into one commit, not touching configure.ac (thanks).

And indeed, it now tests something :-)

[==========] Running 3 test(s).
[ RUN      ] xkey_provider_test_fetch
[       OK ] xkey_provider_test_fetch
[ RUN      ] xkey_provider_test_mgmt_sign_cb
[       OK ] xkey_provider_test_mgmt_sign_cb
[ RUN      ] xkey_provider_test_generic_sign_cb
[       OK ] xkey_provider_test_generic_sign_cb
[==========] 3 test(s) run.
[  PASSED  ] 3 test(s).
PASS: provider_testdriver

and just an empty "PASS: provider_testdriver" when compiled without
XKEY.

Your patch has been applied to the master branch.

commit 4fe50675946f4533a9a373f4332e417f1bbfeabe
Author: Selva Nair
Date:   Thu Jan 20 11:16:16 2022 -0500

     Add a unit test for external key provider

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Message-Id: <20220120161616.13447-1-selva.n...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23608.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to