There is not much to test here yet - so what I did was "test that it
does not break with ossl 1.x" (it doesn't), that it does not compile
anything into xkey_provider.o when compiled with 3.0.0 (it doesn't)
and that it *does* with 3.0.1

3.0.0$ size src/openvpn/xkey_provider.o 
   text    data     bss     dec     hex filename
     48       0       0      48      30 src/openvpn/xkey_provider.o

3.0.1$ size src/openvpn/xkey_provider.o 
   text    data     bss     dec     hex filename
   1534     176       0    1710     6ae src/openvpn/xkey_provider.o


As far as I can see, the xkey stuff is not actually referenced anywhere,
so "it is not compiled on MSVC builds" won't break anything *yet*, but
it might as soon as actually linked-in.

Your patch has been applied to the master branch.

commit 5910eb6cd5308720d5e4f197b83763d572fce8a1
Author: Selva Nair
Date:   Tue Dec 14 11:59:11 2021 -0500

     A built-in provider for using external key with OpenSSL 3.0

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Message-Id: <20211214165928.30676-2-selva.n...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23446.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to