Acked-by: Gert Doering <g...@greenie.muc.de>

With the latest comment changes (v2/2) and wiscii's grammar fix these
code parts are now much easier to understand.

There is not much to actually test yet, as the new functions are not
called.  I have visually compared with crypto_adjust_frame_parameters()
and "it seems to do the smae thing" (if(occ)).

The comments in mtu.h are helpful to understand the terminology used
regarding "header" and "payload (including compression *header*").

Your patch has been applied to the master branch.

commit de018b5e93d6a85f39e5e8ecd3c986320fde8a2f
Author: Arne Schwabe
Date:   Wed Dec 29 17:34:45 2021 +0100

     Add helper functions to calculate header/payload sizes

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20211229163445.1893687-1-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23476.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to