Am 10.12.21 um 17:17 schrieb Frank Lichtenheld:
Arne Schwabe <a...@rfc2549.org> hat am 07.12.2021 18:01 geschrieben:
This code is probably from a time when we could not set the MTU on
the Windows tap6 driver. Nowadays we can set the MTU on this device,
so this code is a noop now.
[...]
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 75d5eaf7b..12bdd2005 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -6071,7 +6071,6 @@ tuntap_get_mtu(struct tuntap *tt)
&mtu, sizeof(mtu),
&mtu, sizeof(mtu), &len, NULL))
{
- tt->post_open_mtu = (int)mtu;
msg(D_MTU_INFO, "TAP-Windows MTU=%d", (int)mtu);
}
}
This change makes no sense to me. Why would you not remove the complete
tuntap_get_mtu call? If the whole point was to get the MTU, and now it will be
the one we set, why even to the ioctl at all?
I wanted to keep the message that is currently printed at verb 1. If we
decide that the message can be removed I can remove the calling of the
ioctl as well.
Arne
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
