Hi, > Why not just use 0 offset always? Perpetuating this dance of 0 offset in some > cases, -1 otherwise is not a way forward. Also see my patch from 2015 that > never got any traction. I have lost touch with the context, so, I'm not sure > whether this addresses the same (apart from code changes) or something > related. > > https://sourceforge.net/p/openvpn/mailman/openvpn-devel/thread/1449454660-20050-1-git-send-email-selva.nair%40gmail.com/#msg34674818 > > Also: > https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13413.html > and other messages in that thread.
Thanks for pointing me out to this, obviously I missed your original patch and that discussion. I don't know why there is an offset in the first place for both openvpn2 and openvpn3, there is probably some reason for it? I wanted to be on the safe side and use a network address for some cases only (small subnet). If you think it is safe to always use 0, let's do that - I can send V2. I tried to apply your patch but it doesn't apply anymore - tun.c has changed a lot since 2015. What comes to discussion about getting rid of the offset option - since the syntax is like this: --ip-win32 dynamic [offset] [lease-time] we cannot just remove [offset] since we might break configurations which set [lease-time]. -- -Lev _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
