Your patch has been applied to the master branch.
As discussed on IRC, the Changes.rst entry was extended, and the
--cipher entry in the manpage (doc/man-sections/protocol-options.rst)
was replaced with the new text. I'm not sure if it is clear enough
now, so I susggest we revisit the whole "document ciphers and NCP"
topic in the "pre-release" phase for 2.6 - Richard's help would
certainly be most welcome there.
The code itself looks reasonable. Some basic tests with my current
t_client rig confirms that it broke all the "--cipher BF-CBC" tests
(that had this explicitly added because NCP broke the frame stuff,
thus "big packets"). Adding "--data-ciphers BF-CBC" fixed those
tests, and so did "--compat-mode 2.4.0".
commit 65f6da8eeb84fbcea357765e13fa73d0169a143c
Author: Antonio Quartulli
Date: Sat Sep 4 11:56:26 2021 +0200
do not include --cipher value in data-ciphers
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
Acked-by: Arne Schwabe <a...@rfc2549.org>
Message-Id: <20210904095629.6273-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22799.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
