Hi, On 02/08/2021 15:31, Gert Doering wrote: > Mixed udp+tcp configs can not have --explicit-exit-notify in them > today because this option is refused in TCP mode. At the same time, > it was always possible to push the option both in UDP and TCP mode > (with a warning logged in TCP mode, and the option reset to 0). > > Do the same thing for local config - warn, and reset to 0. > > (Leaving it enabled in TCP mode is harmless, but causes extra error > messages in the log which is undesired behaviour. Maybe one should > just fix the underlying logic for TCP mode instead, but this is more > invasive) > > Signed-off-by: Gert Doering <g...@greenie.muc.de>
I gave this patch a run in various udp/tcp combinations and it all looked good to me. Having both: proto tcp explicit-exit-notify in the client config does not lead to any fatal error anymore. The client logs the fact with a NOTICE and moves on. If the server will also push explict-exit-notify, the client will log once again, as always happened (this behavior wasn't modified). The same behavior can be observed on the server side. Code change looks good and small enough :) Acked-by: Antonio Quartulli <anto...@openvpn.net> -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
