Acked-by: Gert Doering <g...@greenie.muc.de>
Looks reasonable. Getting more test coverage on MSVC is good.
Will this put build artefacts somewhere where people can download
and test MSVC builds? Or is it "just openvpn.exe", but not a complete
installer? The file looks like "*.exe and *.dll" (but at least this).
Where does it report compile errors to?
Your patch has been applied to the master and release/2.5 branch.
commit e007cc260edb0f24ad8f8468fbe7daf9efde85dc (master)
commit 1ca147bd716b4f756072c44fe7713f05f147bfc6 (release/2.5)
Author: Lev Stipakov
Date: Tue Jun 15 15:56:16 2021 +0300
GitHub actions: add MSVC build
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20210615125616.344-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22556.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
