Acked-by: Gert Doering <[email protected]>
I have no idea about all this MSVC building but Samuli has tested this,
so it's supposedly working :-) - but it does not touch actual OpenVPN
Code and "generally looks reasonable".
Your patch has been applied to the master and release/2.5 branch
(we want this in release/2.5 to be able to do a 2.5.3 release with
arm64 support).
There is one bit that warrants looking twice - removal of
compat-inet_pton.c/ntop.c from compat.vcxproj.filters - in master,
these files are gone, while they still exist in 2.5. We do not *use*
them in 2.5 on windows either, as all supported windows versions have
these functions now. So this is good.
commit 56f775fe9dacab7804109e305d652057b0c7fd3c (master)
commit 206d9665a80de997b0b74707ec880879617cba9a (release/2.5)
Author: Lev Stipakov
Date: Fri May 14 07:57:04 2021 +0300
msvc: standalone building
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg22389.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
