Hi, On 04/06/2021 16:39, Arne Schwabe wrote: > Previously we relied on checking tls_authentication_status to check > wether to determine if the context auth state is actually valid or not. > This patch eliminates that check by introducing waiting on the > authentication as extra state in the context auth, state machine. > > Patch v3: Fix ccd config from management being ignored > Patch v4: Fix race condition, we need to accept the config from > management if we are in CAS_WAITING_AUTH or earlier states > and not just in CAS_WAITING_AUTH state > > Signed-off-by: Arne Schwabe <a...@rfc2549.org>
This patch gets an ACK from me because all my tests have passed and I find the code reasonable. My compile zoo was happy too. My tests included client/server, with auth, with deferred auth, p2p. I have not tested this patch using the mgmt interface. Acked-by: Antonio Quartulli <anto...@openvpn.net> >From now on, when Acking a patch I will imply that: * my GitLab CI is all green with this patch applied; * the patch compiled against mbedtls (various versions), openssl (various versions), libressl (various versions), wolfssl (master branch). This way I don't have to talk about my compile zoo every time :-) -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
