Hi On Wed, Jun 9, 2021 at 2:15 AM Antonio Quartulli <a...@unstable.cc> wrote:
> From: Arne Schwabe <a...@rfc2549.org> > > clang does not like if the format argument of printf like function > is not a string literal (or constant): > > warning: format string is not a string literal (potentially insecure) > > Make the format string constant to silence the warning. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org> > Signed-off-by: Antonio Quartulli <a...@unstable.cc> > --- > > Changes from v1: > * use const string instead of introducing "%s". > > @Arne I anticipated this change because I "assumed" you would be ok with > it (patch is still yours), but feel free to comment of course. > > > src/openvpn/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index 819979b1..086f7b6e 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -2069,7 +2069,7 @@ check_ca_required(const struct options *options) > return; > } > > - const char* str = "You must define CA file (--ca)" > + const char* const str = "You must define CA file (--ca)" > #ifndef ENABLE_CRYPTO_MBEDTLS > " or CA path (--capath)" > #endif > -- > 2.31.1 > Changes from v1: > * use const string instead of introducing "%s". > @Arne I anticipated this change because I "assumed" you would be ok with > it (patch is still yours), but feel free to comment of course. > In that spirit, assuming Antonio would have acked this had it been submitted by Arne, I'm ready to ack this on his behalf.. Acked-by: <selva.n...@gmail.com> masquerading as "pick-your-name" Earnestly hoping these lines don't show up again in a patch for a very long time to come.. Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
