Hi, On Fri, May 14, 2021 at 10:31 AM Lev Stipakov <lstipa...@gmail.com> wrote: > > From: Lev Stipakov <l...@openvpn.net> > > pkcs11-helper is a dependency library used by OpenVPN. > So far it has been built only by mingw. > > Since we're making MSVC build system a first class citizen, > we need to build depencencies with MSVC, which we do with vcpkg. > All dependencies are in vcpkg official repo, expect pkcs11-helper. > > This provides vcpkg port for building pkcs11-helper. > > Example usage: > > vcpkg --overlay-ports=<openvpn>\contrib\vcpkg-ports install pkcs11-helper
Part of the changes here -- especially that of config-win32-vc.h should go upstream to pkcs11-helper isn't it? In fact it may have to be added to config-win32-vc.h.in as the former is a generated file. Was it rejected upstream and we have to maintain this ourselves? Also the patch adding the RFC 7512 (pkcs11: URI) serialization is applied in openvpn-build as well. Adding a patch inside a patch already makes it so hard to read/review and keep current, and now having the same in two places would add to that burden. Is there any real advantage of building openvpn.exe directly from here as opposed to from openvpn-build? Anyway, for Windows releases we need more than openvpn.exe. Selva _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
