Hi, On 10/05/2021 15:13, Arne Schwabe wrote: > The caching in tls_authentication_status broke the quick reaction to > authentication status in the code paths that did not do caching like > PUSH_REQUEST reply code path. > > This patch introduces exponential backoff for the caching so we still > retain the quick reaction while still keeping the benefit of caching. > > Signed-off-by: Arne Schwabe <[email protected]>
Very simple and nice patch that removes the static caching interval and makes it dynamic, following an exp backoff. Logic is very simple and various latency values are hardcoded in an array - so no need for any math. Tests reveal that the delay introduced with the previous patch (Return cached result in tls_authentication_status) is indeed killed. Should the deferred auth script/plugin take a bit longer, we will see some delay being introduced, but still very reasonable. Acked-by: Antonio Quartulli <[email protected]> Bonus: if fixes a comment and a typ0. Regards, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
