Am 01.05.21 um 15:06 schrieb Antonio Quartulli:
> From: Antonio Quartulli <anto...@openvpn.net>
>
> warn_used is a static variable but that is used only under certain
> conditions. These conditions do not apply for Windows and therefore
> mingw is spitting a warning for unused variable.
>
> Move variable declaration inside code block that uses it.
>
> Fixes:
>
> run_command.c: In function ‘openvpn_popen’:
> run_command.c:236:17: warning: unused variable ‘warn_shown’
> [-Wunused-variable]
> 236 | static bool warn_shown = false;
> | ^~~~~~~~~~
>
> Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
> ---
> src/openvpn/run_command.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/openvpn/run_command.c b/src/openvpn/run_command.c
> index 34f95c5c..650876c1 100644
> --- a/src/openvpn/run_command.c
> +++ b/src/openvpn/run_command.c
> @@ -233,11 +233,11 @@ openvpn_popen(const struct argv *a, const struct
> env_set *es)
> {
> struct gc_arena gc = gc_new();
> int ret = -1;
> - static bool warn_shown = false;
>
> if (a && a->argv[0])
> {
> #if defined(ENABLE_FEATURE_EXECVE)
> + static bool warn_shown = false;
> if (script_security() >= SSEC_BUILT_IN)
> {
> const char *cmd = a->argv[0];
>
Acked-By: Arne Schwabe <a...@rfc2549.org>
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
