Hi, On 01/05/2021 15:33, Antonio Quartulli wrote: >> multi->tas_last = now; > > I think keeping this line here is wrong. > > Now that the logic has been changed, the code is setting tas_last to now > every time this function is called (it wasn't the case before this patch). > > For this reason "cached" will always be true and the ACF will never be > checked. > > A fix would be to add a condition above this line, like: > > if (!cached) > multi->tas_last = now;
I think it may even be better to move these two lines above right after having invoked key_state_test_auth_control_file() - unless there is some drawback that I can't see. Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
