Hi, On 06/04/2021 23:01, Antonio Quartulli wrote: > > I like the new approach a lot. > It definitely helps keeping track of "what compat code do we need? and > for which version?" > > Just one suggestion: > I think it would still be useful to add a comment on the #endif line to > explicitly say what if we are closing. > > i.e: > > #endif /* OPENSSL_VERSION_NUMBER < 0x10101000L && > !defined(ENABLE_CRYPTO_WOLFSSL) */ > > That helps your brain when the corresponding #if is far away or you have > more than one nearby. > > Other than that, it compiles on openssl-1.1.1, 1.1.0 and 1.0.2. > Test on Linux and Windows (openssl-1.1.1 only in this case).
Since Gert has volunteered to fix this comment on the fly, I am fine with this version of the patch. Acked-by: Antonio Quartulli <anto...@openvpn.net> -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
