From: Antonio Quartulli <anto...@openvpn.net> There is no need to check the result of a boolean function and then assign a constant value to a variable based on that check.
Directly assign the return value of the function to the variable. Signed-off-by: Antonio Quartulli <anto...@openvpn.net> --- src/openvpn/ssl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 9d18c6e5..cb2a3e82 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -1614,10 +1614,8 @@ openvpn_PRF(const uint8_t *secret, } /* compute PRF */ - if (!ssl_tls1_PRF(BPTR(&seed), BLEN(&seed), secret, secret_len, output, output_len)) - { - ret = false; - } + ret = ssl_tls1_PRF(BPTR(&seed), BLEN(&seed), secret, secret_len, output, + output_len); buf_clear(&seed); free_buf(&seed); -- 2.26.3 _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel