Hi, On Sat, Apr 03, 2021 at 08:46:26PM +0200, Arne Schwabe wrote: > Using OpenVPN without P2MP support (pull, TLS) is unrealistic and > building a binary without it is not something we realistically want > to support anyway. Building P2MP support now only depends on > HAVE_GETTIMEOFDAY or win32, which has a compat function for it. > > This also removes the ENABLE_SHAPER and TIME_BACKTRACK_PROTECTION > defines, which also depend only on the HAVE_GETTIMEOFDAY or WIN32. > > I kept the configure.ac check and ifdef in compat since mingw actually > provides a gettimeofday and we will use that instead of our own compat > function. > > Patch V2: Remove dco parts that slipped into the patch, mention the > other removed defines that are always enabled.
I need to NAK this, I'm afraid.
There's a few random stray blank lines, which I could have removed
on the fly :) - and the commit message as well, but I think you need
to look at TIME_BACKTRACK_PROTECTION more closely.
The #define is gone, but the code in otime.h still #if's on it, and
I think "we want the one *with* TIME_BACKTRACK_PROTECTION"... so either
totally remove the other branch, or leave the #define at "1" (for this
patch).
My suggestion for a changed commit mesage was as follows:
-------------- snip --------------
Remove conditionals compilation for P2MP, ENABLE_SHAPER and check for
gettimeofday
Using OpenVPN without P2MP support (pull, TLS) is unrealistic and
building a binary without it is not something we realistically want
to support anyway. Building P2MP support currently only depended
on HAVE_GETTIMEOFDAY or _WIN32, which has a compat function for it.
Remove all the #ifdef P2MP logic, simplify code and reduce maintenance
effort.
This also removes the ENABLE_SHAPER and TIME_BACKTRACK_PROTECTION
defines, which also depended only on the HAVE_GETTIMEOFDAY or WIN32.
-------------- snip --------------
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
