Hi, On 28/03/2021 14:02, Arne Schwabe wrote: > context_2 and tls_multi have the same life cycle for TLS connections > but so this move does not affect behaviour of the variable. > > OpenVPN TLS multi code has a grown a lot more complex and code that > handles multi objects needs to know the state that the object is in. > Since not all code has access to the context_2 struct, the code that > does not have access is often not checking the state directly but > checks other parts of multi that have been affected from a state > change. > > This patch also renames it to multi_state as this variable represents t > he multi state machine status rather than just the state of the connect > authentication (more upcoming patches will move other states > into this variable). > > Patch V2: also rename context_auth to multi_state, explain a bit why this > change is done.
Thanks a lot. Much better now! > > Signed-off-by: Arne Schwabe <a...@rfc2549.org> As explained in the commit message, this patch is really just a field move and it's expected to not change any behaviour. On top of that it is being moved between two objects sharing the same lifecycle. Basic tests pass. Compiled tested against my usual SSL libs zoo. Acked-by: Antonio Quartulli <anto...@openvpn.net> -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
