Acked-by: Gert Doering <g...@greenie.muc.de>

Taking Antonio's ACK on v3, adding my own (positive) test results on v5
to make my own ACK.

The code of v3 and v5 only differs in one line

++            || (options->ncp_enabled && tls_item_in_cipher_list("BF-CBC", 
options->ncp_ciphers))

which covers the special case broken in v3 (talking to a 2.4 server with
--ncp-disable).  Server side tests all succeed as well.

Your patch has been applied to the master branch.

commit 79ff3f79ebd98b880e77f323bd591eeb85df8411
Author: Arne Schwabe
Date:   Fri Feb 19 17:52:52 2021 +0100

     Allow running a default configuration with TLS libraries without BF-CBC

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Antonio Quartulli <anto...@openvpn.net>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20210219165252.4562-1-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21577.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to