Hi,

On Fri, Mar 26, 2021 at 12:12:40AM +0100, Antonio Quartulli wrote:
> > -#ifdef HAVE_EVP_CIPHER_CTX_SET_KEY_LENGTH
> > +    /* This serves as a check that the keylen is the correct as this fails
> > +     * when key_len and the fixed size of cipher disagree */
> >      if (!EVP_CIPHER_CTX_set_key_length(ctx, key_len))
> 
> Are you sure we need to keep this check?

Indeed, that also got me wondering (and is the reason why I didn't
just ack-and-merge it right away :-) - but I was waiting for someone
else to understand and ACK this)

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to