Acked-by: Gert Doering <g...@greenie.muc.de>

On non-windows, socket_descriptor_t is typedef'ed to "int", so this is
no "generated code change", just ensuring consistency in our types.  On
Windows, this is a "SOCKET", which might or might not fit into an int,
but is certainly not interchangeable.  So, makes sense.

Compile-tested on MinGW, lightly client-tested on FreeBSD and Linux.

Your patch has been applied to the master branch.

commit e756e12adb33e93f712281361ae61a1522d3df93
Author: Arne Schwabe
Date:   Wed Mar 24 23:23:29 2021 +0100

     Fix socket related functions using int instead of socket_descriptor_t

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20210324222330.455-3-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21806.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to