On 18/03/2021 19:12, Juliusz Sosinowicz wrote:
PKG_CHECK_VAR is not available on older versions of autoconf. This
patch copies the definition generated by newer versions of autoconf to
be used for compatibility with older versions. Tested with automake
1.14.1-2ubuntu1 and autoconf 2.69-6.
Signed-off-by: Juliusz Sosinowicz <juli...@wolfssl.com>
I ended up doing some more investigation here, to better understand
where this could fail.
So it seems this is not related to automake/autoconf versions. It is
related to pkg-config version, which is the one providing
/usr/share/aclocal/pkg.m4 which provides the PKG_CHECK_VAR() macro.
<https://gitlab.freedesktop.org/pkg-config/pkg-config/-/commit/5b463c927b6caeb332bb147572ea82b1650ceb7d>
What surprises me is that this was added to pkg-config 0.28, which was
released in 2013-01-24. The latest release, 0.29.2 was released 2017-03-20.
<https://gitlab.freedesktop.org/pkg-config/pkg-config/-/commit/74ceac54ef6f9247c00f08eecd8cca811a3c5934>
<https://gitlab.freedesktop.org/pkg-config/pkg-config/-/tags>
It would be great to figure out if pkg-config is available on those
build hosts failing without this change. If it is present, it needs to
be checked which version it is.
If this is due to an outdated pkg-config, I'm reluctant to give this
patch an ACK. Using properly up-to-date dependency stack should be a
reasonable precondition to build OpenVPN. If it is due to unavailable
pkg-config, it's a different story.
Regardless, the commit message is incorrect. But that can probably be
fixed at commit time.
--
kind regards,
David Sommerseth
OpenVPN Inc
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
