Acked-by: Gert Doering <[email protected]>
Tested with exactly that testbed that initially discovered the SIGSEGV,
and as expected, it no longer crashes. Verified that it still crashes
with "--verb 8" (it does).
Code also looks secure and does what it says on the lid.
That said, ACKed and merged, I'm still not totally happy with the
approach chosen - this is quite some new lines of code to change one
"3" into a "2", depending on the value of one other variable... but we
discussed this before, and Arne did not want to have the mbedTLS code
"peek" into get_debug_level() to get at the --verb setting. Since
Steffan is fine with this approach, I'm clearly the minority here...
.. while writing this, the ACK from Steffan came in... so, recording
that as well... MULTI-ACK! :-) - and fixing the comment as requested.
Your patch has been applied to the master and release/2.5 branch
(stability / long-term compat thing).
commit 4524feb2bbbb6d1bd463a0c5c2d53aae5bdf360a (master)
commit 475d17a53eba85591f270008f8b583383a5b9afa (release/2.5)
Author: Arne Schwabe
Date: Tue Mar 16 13:44:21 2021 +0100
Avoid generating unecessary mbed debug messages
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg21667.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
