Am 15.01.21 um 14:13 schrieb Lev Stipakov:
> Hi,
> 
> Please not that I got errors applying this patch, so I reviewed
> corresponding commit
> from github 
> (https://github.com/schwabe/openvpn/commit/3901e46127a2db3e6dfb20c44e8d8e30adea58c7).
> 
>> +Receiving a AUTH_PENDING message will make the client change its timeout the
>> +timeout proposed by the server, even if the timeout is shorter.
> 
> Typo.
> 
> 
>>  /*
>>   * min/max functions
>>   */
>> +static inline unsigned int
>> +max_uint(unsigned int x, unsigned int y)
> 
> It is 2021 and we have to write our own min/max :(

Yes. We had a discussion on #openvpn-devel and there seem to be no
(non-float) min/max version in the standard library. The linux kernel
also has a macro for this. This would be min_t(unsigned int, x, y) iirc
in the kernel, so similar to what we do here

Arne


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to