Hi Thanks for the comments.
On Fri, Dec 25, 2020 at 3:03 PM Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, Dec 20, 2020 at 07:31:42PM -0500, Selva Nair wrote: > > Here is the link again. > > https://github.com/selvanair/openvpn-gui/releases/tag/v11-echo-msg > > I got no feedback then nor now. > > I have stared at the code a bit, and it seems to make sense. The part > "store a digest + timestamp, and avoid repeating the same message for > <n> hours" is a good idea. > > I can see that "echo_msg_clear()" has a bool parameter to clear the > message history but I can not see a call with "true" - what did you > have in mind? A button to clear the messages history? Or "if changing > to a different profile"? > It has been a while... The history needs to be cleared to free up memory when the thread is terminated on disconnect. Looks like a bug if it's not done during cleanup. That said, I see that I have newer versions of this echo-msg branch (upto v4) in my local repo and the latest includes persisting the history in registry and clearing before disconnect. > I have not tested the binary. > Don't. While we are in this blessed "One True Echo" state, let me rebase the latest version, do some quick tests and post it as a PR for review & comments. Have to do that before I again get stuck in procrastination and the desire to add more glitter like urls in message text etc.. Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
