From: Lev Stipakov <l...@openvpn.net>

Commit cc5a71637 ("Replace key_scan array of static pointers with inline 
function")
has introduced get_key_scan() routine with switch statement which calls ASSERT
in certain case. Even though "this should never happen", this code triggers 
Level 1
warning "not all control paths return a value" in msvc.

Fix by adding "return NULL; /* NOTREACHED */"" after ASSERT.

Signed-off-by: Lev Stipakov <l...@openvpn.net>
---
 src/openvpn/ssl_common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h
index f435089a..a826e37f 100644
--- a/src/openvpn/ssl_common.h
+++ b/src/openvpn/ssl_common.h
@@ -596,6 +596,7 @@ get_key_scan(struct tls_multi *multi, int index)
             return &multi->session[TM_LAME_DUCK].key[KS_LAME_DUCK];
         default:
             ASSERT(false);
+            return NULL; /* NOTREACHED */
     }
 }
 
-- 
2.17.1



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to