Acked-by: Gert Doering <g...@greenie.muc.de> Not sure if I ever understood these shortcuts (there are 3*2 keys in session[].keys[], but the shortcuts only reference [0][0], [0][1] and [2][1]) but from a "mechanically comparing before/after" point of view, the change looks sane.
Plus, it passes client side tests, with short reneg timeouts (20s). This change, of course, makes it more interesting to do backports of ssl.c-related changes from master/2.6 to 2.5... so let's get out 2.6 quickly :-) Uncrustify complains about indent of the new switch/case block, and that there is a trailing semicolon. Fixed. *Also*, this patch needed to be (manually) rebased due to context conflicts after 0d4ca79d4f. Done. "points" -> "pointers", as requested. Your patch has been applied to the master branch. commit cc5a71637139557a7eaa024251ff75a0acb22bc8 Author: Arne Schwabe Date: Fri Oct 23 14:02:53 2020 +0200 Replace key_scan array of static pointers with inline function Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20201023120259.29783-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21225.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel