Hi, On Thu, Sep 17, 2020 at 08:55:07AM +0200, Antonio Quartulli wrote: > > } > > > > pool->ipv6.base = ipv6_base; > > + > > + /* if a pool starts at ::0, that first IPv6 address is not usable > > can we reword a bit this comment? I.e.: "if the starting address of a > pool has the host part all zero, that first ...." > > The "starts at ::0" confused me as if we were targeting pools starting > at [::].
Okay. I did not want to make this comment too long, but it seems more
verbosity is needed. I'll send a v2
> > + * first clients (subnet anycast address). Start with 1, then.
> > + * NOTE: this will also fire for something like
> > + * ifconfig-ipv6-pool 2001:db8:0:1:1234::0/64
> > + * as we only look at the rightmost 32 bits. So be it...
>
> wouldn't this test miserably fail when the host part is smaller than 32?
> like for a 2001:db8:0:1:1234::0/124?
We look at "base", which is only the host part, but "at most 32 bits of
the host part".
(This is *your* code...!)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
