On 17/09/2020 00:05, Arne Schwabe wrote:
> This snippet in the configure.ac looks strange:
>
> if test -n "${WOLFSSL_DIR}"; then
> wolfssldir="${WOLFSSL_DIR}"
> else
> wolfssldir="/usr/local/include/wolfssl"
> fi
>
> I am not sure hardcoding a /usr/local path is something we want/allow.
> The people better at autoconf might have a better idea on this.I'll bite on this one. You seem to install wolfssl.pc in an appropriate directory, so it should really pull the default path using PKG_CHECK_MODULES instead. Having overrides. like we do with OpenSSL (with OPENSSL_LIBS and OPENSSL_CFLAGS), is fine. The main challenge with the pkg-config is that it must use the same directory on the system as the rest of the development packages uses. This is usually not an issue for developers using a distro package of the library; these packages install all these pkg-config files in the appropriate directory. The challenge is more for those compiling and installing unpackaged versions of the library; which is where the WOLFSSL_LIBS and WOLFSSL_CFLAGS comes into play. -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
