Hi, On 09/09/2020 14:22, Gert Doering wrote: > diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c > index 57f0cee2..d43d84a8 100644 > --- a/src/openvpn/socks.c > +++ b/src/openvpn/socks.c > @@ -312,7 +312,7 @@ recv_socks_reply(socket_descriptor_t sd, > char atyp = '\0'; > int alen = 0; > int len = 0; > - char buf[22]; > + char buf[270]; /* 4 + alen(max 256) + 2 */ > const int timeout_sec = 5; > > if (addr != NULL) > @@ -381,7 +381,10 @@ recv_socks_reply(socket_descriptor_t sd, > break; > > case '\x03': /* DOMAINNAME */ > - alen = (unsigned char) c; > + /* RFC 1928, section 5: 1 byte length, <n> bytes name, > + * so the total "address length" is (length+1) > + */ > + alen = (unsigned char) c +1;
since you are touching this line...how about making it straight? 1) why casting to unsigned char? "alen" is int. 2) please add a space after the '+' operator. Regards, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
