>  /*
>   * Send restart message from server to client.
>   */
> diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h
> index 96897e48..b5cc9dc9 100644
> --- a/src/openvpn/ssl_common.h
> +++ b/src/openvpn/ssl_common.h
> @@ -576,6 +576,7 @@ struct tls_multi
>  
>      char *remote_ciphername;    /**< cipher specified in peer's config file 
> */
>  
> +    bool connection_established; /** Notifies future auth calls this is a 
> reneg */
>      /*
>       * Our session objects.
>       */
>

NAK from my side. Adding another variable to state machine for just this
feature that duplicates already existing states is something I really
want to avoid. This might look and work fine for this patch but at the
end you end up with a plenthora of mini states and unclear
interdependency. I worked hard in the connect-client patches to remove
duplication of these states and are not eager to reduce them, especially
not "connection_established" which duplicates the name of
link_socket->connection_established that has a completely different meaning.

Arne

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to