Hi, On 11/07/2020 11:36, Arne Schwabe wrote: > From: Fabian Knittel <fabian.knit...@lettink.de> > > This patch splits up the multi_connection_established() function. Each new > helper function does a specific job. Functions that do a similar job receive > a > similar calling interface. > > The patch tries not to reindent code, so that the real changes are as clearly > visible as possible. (A follow-up patch will only do indentation changes.) > > Signed-off-by: Fabian Knittel <fabian.knit...@lettink.de> > > PATCH v3: Since the code has changed enough from the time the original patch > to the current master, the splitting has been redone from the current code. > Also some style and minor code changes have been added doing this patch. > This elimininates and the big reformatting done before eliminates the follow > up patch with indentation changes. > > The original patch already replaces some instances of option_permission_mask > with CLIENT_CONNECT_OPT_MASK. The V3 version does this more consistenly. > > Patch v4: Move config -> mi->cc_config into its own commit > > Patch v5: Clean up some minor issues, add one missing check on > temporary file deletion, rebase on latest master. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Thanks for taking care of my concerns. The patch looks good and does what it says. Unfortunately the code itself is already pretty convoluted, so this refactoring patch looks convoluted as well...but after looking through it the change is minimal. Acked-by: Antonio Quartulli <anto...@openvpn.net> -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
