Hi, On Sat, Jul 11, 2020 at 11:36:44AM +0200, Arne Schwabe wrote: > From: Fabian Knittel <fabian.knit...@lettink.de> > > Refactor multi_client_connect_source_ccd(), so that options_server_import() > (or > the success path in general) is only entered in one place within the function. > > Signed-off-by: Fabian Knittel <fabian.knit...@lettink.de>
All server side tests passed
23...
Test sets succeeded: 1 1a 1b 1d 2 2a 2b 2c 2d 3 4 5 6 8 8a 9.
Test sets failed: none.
24...
Test sets succeeded: 1 1a 1b 1c 1d 1e 2 2a 2b 2c 2d 2e 3 4 4a 5 6 8 8a 9.
Test sets failed: none.
master...
Test sets succeeded: 1 1a 1b 1c 1d 1e 2 2a 2b 2c 2d 2e 3 4 5 6 7 7a 8 8a 9 2f
4b.
Test sets failed: none.
which is NOT a conclusive test in this case, because I do not have
clients setup with ccd/DEFAULT here. So this is more "it does not break
anything else".
I do not like the indentation and wrapping, though:
> + const char *ccd_client =
> platform_gen_path(mi->context.options.client_config_dir,
> +
> tls_common_name(mi->context.c2.tls_multi,
> + false),
> + &gc);
instead, maybe this?
> + const char *ccd_client =
> + platform_gen_path(mi->context.options.client_config_dir,
> + tls_common_name(mi->context.c2.tls_multi,
> + false), &gc);
or maybe we want to extract "tls_common_name(..., false)" into a temp
variable here?
> + const char *cn = tls_common_name(mi->context.c2.tls_multi, false);
> + const char *ccd_client =
> + platform_gen_path(mi->context.options.client_config_dir,
cn, &gc);
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
