Hi,
On Tue, Jun 30, 2020 at 04:15:58PM +0200, Jan Just Keijser wrote:
> On 30/06/20 16:11, Gert Doering wrote:
> > On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote:
> >> @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const
> >> struct tuntap_options *o)
> >> write_dhcp_u32_array(buf, 42, (uint32_t *)o->ntp, o->ntp_len,
> >> &error);
> >> write_dhcp_u32_array(buf, 45, (uint32_t *)o->nbdd, o->nbdd_len,
> >> &error);
> >>
> >> + for (int i=0; i < o->domain_search_list_len; i++)
> >> + {
> >> + write_dhcp_search_str(buf, 119, o->domain_search_list[i], &error);
> >> + }
> > I assume that this won't work. In the DHCP answer, it must be a single
> > option with the concatenated list, not multiple answers with a single
> > domain name each.
>
> see https://tools.ietf.org/html/rfc3397
>
> "
>
> In the above diagram, Searchstring is a string specifying the
> searchlist. If the length of the searchlist exceeds the maximum
> permissible within a single option (255 octets), then multiple
> options MAY be used, as described in "Encoding Long Options in the
> Dynamic Host Configuration Protocol (DHCPv4)" [RFC3396
> <https://tools.ietf.org/html/rfc3396>].
>
> "
> so you MAY use this option multiple times - and wireshark groks it fine. I
> don't have a Windows 10
> client to test it against, however, so I am hoping that someone (Selva?) can
> do that for me.
I did test, and my initial suspicion was correct - Windows accepts the
option, but only one of them.
I am pushing
dhcp-option DOMAIN-SEARCH v6.de,dhcp-option DOMAIN-SEARCH leo.org,dhcp-option
DOMAIN-SEARCH ov.greenie.net,dhcp-option DOMAIN-SEARCH nekosoft.de
(because these are domains that have more interesting hostnames in than
just "www" and "mail", so I can see if "v4only.v6.de" is found, or
"dict.leo.org")
and "ipconfig /all" only shows the "nekosoft.de" one.
This one works(!), so generally, Win10 accepts this DHCP option - but
it seems to want "all domains in one".
Can you send a v3?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
