On 18/05/2020 17:54, Arne Schwabe wrote:
> After the commit 042429d3 "build: Remove --disable-server from ./configure"
> Android needs another way to ensure that OpenVPN is not run in server mode.
>
> Signed-off-by: Arne Schwabe <a...@rfc2549.org>
> ---
> src/openvpn/options.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/openvpn/options.c b/src/openvpn/options.c
> index 2da8cf6d..bfba62ad 100644
> --- a/src/openvpn/options.c
> +++ b/src/openvpn/options.c
> @@ -2254,6 +2254,9 @@ options_postprocess_verify_ce(const struct options
> *options, const struct connec
> */
> if (options->mode == MODE_SERVER)
> {
> +#ifdef TARGET_ANDROID
> + msg(M_FATAL, "--mode server not supported on Android");
> +#endif
> if (!(dev == DEV_TYPE_TUN || dev == DEV_TYPE_TAP))
> {
> msg(M_USAGE, "--mode server only works with --dev tun or --dev
> tap");
>
Not tested this, but this change is pretty clear and explicit. I also can't
imagine now a better way to tackle this, even though I'm not too happy about
adding more #ifdef.
If someone really needs TARGET_ANDROID with server support, lets wait for them
to appear so we can clearly define the use-case and design a better solution
for a known scenario.
Acked-By: David Sommerseth <dav...@openvpn.net>
--
kind regards,
David Sommerseth
OpenVPN Inc
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
