Am 22.04.20 um 11:26 schrieb Antonio Quartulli: > Carrying around the INLINE_TAG is not really efficient, > because it requires a strcmp() to be performed every > time we want to understand if the data is stored inline > or not. > > Convert all the *_inline attributes to bool to make the > logic easier and checks more efficient. >
Look through it. It is only a minor improvement but Antonio has been
persistent enough and spend enough time to make 9 versions of this so I
took the time to look through it:
Acked-By: Arne Schwabe <arne@rfc2549>
The patch is not uncrustify clean at the moment. So uncrustify should be
run on commit or we need a v10 of this patch.
The patch does not apply cleanly anymore: The test_tls_crypt.c part
should be now.
--- a/tests/unit_tests/openvpn/test_tls_crypt.c
+++ b/tests/unit_tests/openvpn/test_tls_crypt.c
@@ -549,8 +549,7 @@ test_tls_crypt_v2_write_client_key_file(void **state) {
expect_string(__wrap_buffer_read_from_file, filename, filename);
will_return(__wrap_buffer_read_from_file, test_client_key);
- tls_crypt_v2_write_client_key_file(filename, NULL, INLINE_FILE_TAG,
- test_server_key);
+ tls_crypt_v2_write_client_key_file(filename, NULL, test_server_key,
true);
}
static void
@@ -567,8 +566,7 @@
test_tls_crypt_v2_write_client_key_file_metadata(void **state) {
expect_string(__wrap_buffer_read_from_file, filename, filename);
will_return(__wrap_buffer_read_from_file, test_client_key_metadata);
- tls_crypt_v2_write_client_key_file(filename, b64metadata,
INLINE_FILE_TAG,
- test_server_key);
+ tls_crypt_v2_write_client_key_file(filename, NULL, test_server_key,
true);
}
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
