Hi,
On 26-04-2020 11:54, Gert Doering wrote:
> Apply uncrustify 0.70.1 (FreeBSD port) with our rules to that part
> of the tree, which followed a more compact coding style so far.
> ---
>
> @@ -155,20 +157,21 @@ test_packet_id_write_long_wrap(void **state)
> }
>
> int
> -main(void) {
> +main(void)
> +{
> const struct CMUnitTest tests[] = {
> - cmocka_unit_test_setup_teardown(test_packet_id_write_short,
> - test_packet_id_write_setup,
> test_packet_id_write_teardown),
> - cmocka_unit_test_setup_teardown(test_packet_id_write_long,
> - test_packet_id_write_setup,
> test_packet_id_write_teardown),
> -
> cmocka_unit_test_setup_teardown(test_packet_id_write_short_prepend,
> - test_packet_id_write_setup,
> test_packet_id_write_teardown),
> -
> cmocka_unit_test_setup_teardown(test_packet_id_write_long_prepend,
> - test_packet_id_write_setup,
> test_packet_id_write_teardown),
> - cmocka_unit_test_setup_teardown(test_packet_id_write_short_wrap,
> - test_packet_id_write_setup,
> test_packet_id_write_teardown),
> - cmocka_unit_test_setup_teardown(test_packet_id_write_long_wrap,
> - test_packet_id_write_setup,
> test_packet_id_write_teardown),
> + cmocka_unit_test_setup_teardown(test_packet_id_write_short,
> + test_packet_id_write_setup,
> test_packet_id_write_teardown),
> + cmocka_unit_test_setup_teardown(test_packet_id_write_long,
> + test_packet_id_write_setup,
> test_packet_id_write_teardown),
> + cmocka_unit_test_setup_teardown(test_packet_id_write_short_prepend,
> + test_packet_id_write_setup,
> test_packet_id_write_teardown),
> + cmocka_unit_test_setup_teardown(test_packet_id_write_long_prepend,
> + test_packet_id_write_setup,
> test_packet_id_write_teardown),
> + cmocka_unit_test_setup_teardown(test_packet_id_write_short_wrap,
> + test_packet_id_write_setup,
> test_packet_id_write_teardown),
> + cmocka_unit_test_setup_teardown(test_packet_id_write_long_wrap,
> + test_packet_id_write_setup,
> test_packet_id_write_teardown),
> };
This now exceeds 80 chars by a fair amount. Perhaps rewrap?
Otherwise this looks good to me. I think having consistent style over
the code base, including tests, would be good.
-Steffan
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
