Hi,

Since --ncp-ciphers are non-negotiable, why do we need
to store it in context_1 at all? Cannot we use the value
from struct options?

This can be removed
> +    c->c1.ncp_ciphers = c->options.ncp_ciphers;

This
> +    to.config_ncp_ciphers = c->c1.ncp_ciphers;

can be changed to
> +    to.config_ncp_ciphers = options->ncp_ciphers

Those are not needed:
> +    dest->c1.ncp_ciphers = src->c1.ncp_ciphers;
<skip>
> +    const char *ncp_ciphers;    /**< NCP Ciphers */

-Lev


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to