Hi, On 17/02/2020 10:17, Lev Stipakov wrote: > Hi, > >> In the future I suggest splitting unrelated changes like these in >> different patches. >> > > Ok, will send v2 with first change only. > >> This expression simply checks that token contains a value different from >> NULL. It's like a simple "a != 0" - it doesn't matter where that address >> points to, because the pointer is not dereferenced. > > While it works, I think it is cleared to have a flag, rather than check the > address of a dangling pointer.
Yeah, I agree with this statement, but the change you proposed did not make the code any cleaner IMHO. How about adding a boolean found variable (like you did) initialized to false and set it to true inside the if-block, before the break? That would allow the casual reader to understand what is the exact condition that triggers the function to return true. Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
