Hi, Good catch. "Inline" generates inline definition and if we don't do inlining (by not specifying O2), linker doesn't see it and prints an error. Apparently MSVC is lax on that.
Checking source code, most (if all?) or inline methods are static. Obviously we want our code to compile without O2, so ACK from me. Acked-by: Lev Stipakov <lstipa...@gmail.com> ke 5. helmik. 2020 klo 17.41 Domagoj Pensa (doma...@pensa.hr) kirjoitti: > Hi, > > On Wed, Feb 05, 2020 at 10:28:38AM -0500, Selva Nair wrote: > > Are you building without optimization? Please try using the latest > > openvpn-build (or just add -O2 to complier options). > > Yes, that was it! > > When Lev said that he doesn't have problems with build, I've noticed that > he > is using script build-complete from windows-nsis. > > I didn't want installer build, just binaries, so I followed instructions > from README and generic/README and thus I used generic/build. > > But that doesn't include -O2 and I get mentioned error when linking. > > In windows-nsis/build-complete there are additional flags "-O2 -flto" and > that's why Lev doesn't have issues and we are using same tools and OS > versions. > > Those additional flags where added by Lev in commit 3eb61bb in > openvpn-build. > > Problem solved, now I know for the future. > > But still it would be nice to somehow "fix" this for others, by either > updating READMEs, adding -O2 to generic/build script or apply patch I've > sent that helped me and links with optimization off. > > Maybe doing all that won't be bad. > > Thank you all! > > Domagoj > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > -- -Lev
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
