Hi,

+    if (!ValidateOptions(pipe, sud.directory, sud.options)
> +        && !IsAuthorizedUser(ovpn_user->User.Sid, imp_token,
> settings.ovpn_admin_group)
>      {
>

Closing parenthesis is missing:

>C:\Users\lev\Projects\openvpn\src\openvpnserv\interactive.c(1586,5): error
C2143: syntax error: missing ')' before '{'

Also it is probably just me, but took me a while to figure out what that
code is doing and why.

Could you slightly improve the comment above lines you touch
("Check user is authorized or options are white-listed") and mention
something like
"Non-authorized users are allowed to use only white-listed options and
have config only in global openvpn config directory"?

When I started to debug it, I realized that I have to be authorized user
when config
is in my current user's directory (C:\Users\lev\OpenVPN\config) and not in
"global" config
directory ("C:\Program Files\OpenVPN\config"). Is this by design?

-- 
-Lev
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to