Re: [Openvpn-devel] [PATCH v2 7/7] wintun: clear adapter settings on tun close

[Simon Rozman]

Hi,

> -----Original Message-----
> From: Lev Stipakov [mailto:lstipa...@gmail.com]
> Sent: Thursday, November 7, 2019 6:45 PM
> To: openvpn-devel@lists.sourceforge.net
> Cc: Lev Stipakov <l...@openvpn.net>
> Subject: [Openvpn-devel] [PATCH v2 7/7] wintun: clear adapter settings on
tun
> close
> 
>      }
> +    else
> +    if (tt->wintun)
> +    {
> +        netsh_delete_address_dns(tt, false, &gc);
> +    }
>  #endif

    if (tt->wintun && tt->options.msg_channel)
    {
        ...
    }
    else
    if (tt->ipapi_context_defined)
    {
        ...
    }
    else
    if (tt->wintun)
    {
        ...
    }

This construct got a bit convoluted.

Otherwise, LGTM.

Best regards,
Simon

smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel