Hi, > -----Original Message----- > From: Lev Stipakov [mailto:lstipa...@gmail.com] > Sent: Thursday, November 7, 2019 6:45 PM > To: openvpn-devel@lists.sourceforge.net > Cc: Lev Stipakov <l...@openvpn.net> > Subject: [Openvpn-devel] [PATCH v2 6/7] wintun: set adapter properties via > interactive service > > static bool > -do_dns6_service(bool add, const struct tuntap *tt) > +do_dns_service(bool add, const short family, const struct tuntap *tt) > { > bool ret = false; > ack_message_t ack; > struct gc_arena gc = gc_new(); > HANDLE pipe = tt->options.msg_channel; > - int addr_len = add ? tt->options.dns6_len : 0; > + int len = family == AF_INET6 ? tt->options.dns6_len : tt->options.dns_len; > + int addr_len = add ? len : 0; > + char ip_proto_name[5]; > + > + strcpy(ip_proto_name, family == AF_INET6 ? "IPv6" : "IPv4");
const char *ip_proto_name = family == AF_INET6 ? "IPv6" : "IPv4"; ... to avoid the strcpy(). The rest LGTM, so... Acked-by: Simon Rozman <si...@rozman.si> Best regards, Simon
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
